fix(auth): suppress browser output during login #25#98
Open
huda-code wants to merge 3 commits into
Open
Conversation
Author
|
I wasn't able to reproduce the original Chromium/Wayland warnings because my Linux environment uses Firefox as the default browser. This implementation is based on the observation that If this doesn't address the issue in the original environment, I'm happy to revise the implementation or investigate an alternative approach. |
Removed suppression of browser output when opening the browser.
huda-code
commented
Jun 29, 2026
huda-code
left a comment
huda-code
left a comment
Author
There was a problem hiding this comment.
Good catch, thanks! You're right, the suppression was happening twice. I've removed the duplicated inline stdout/stderr logic in the goroutine and now call openBrowserQuietly(loginURL) directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25.
This PR suppresses stdout/stderr from the browser launcher during the authentication login browser-open step.
The reported issue shows Chromium/Wayland-specific warnings being printed to the terminal even though the login succeeds. Since
pkg/browserforwards the launched browser process's stdout and stderr to the CLI, this change temporarily redirects those streams toio.Discardwhile opening the browser, preventing browser-specific output from appearing during the login flow.How to test
go build -o cli .go test ./...xdg-openlaunches the default browser successfully.WAYLAND_DISPLAY=wayland-0).I wasn't able to reproduce the original Chromium/Wayland warnings because my Linux environment uses Firefox as the default browser. This implementation is based on the observation that
pkg/browserforwards the browser launcher's stdout/stderr to the CLI. If this doesn't resolve the issue in the original Chromium-based environment, I'm happy to investigate an alternative approach.